Update app.py

app.py

@@ -78,26 +78,24 @@ class SyntheticDataGenerator:
 
     def get_quality_report_file(self) -> Optional[str]:
         """
-        Build/export the quality report and return a file path for immediate download.
-        Uses /tmp for Spaces; tries ZIP, falls back to TXT.
+        Build/export the quality report and return a file path for download.
+        Uses /tmp on Spaces; tries ZIP first, then TXT fallback.
         """
         if not self.generator:
             return None
         try:
             rep = self.generator.reports(display=False)
 
-            # If a string path to a .zip is returned
+            # Path already?
             if isinstance(rep, str) and rep.endswith(".zip") and os.path.exists(rep):
                 return rep
 
-            # If object exposes a path-like attribute
             for attr in ("archive_path", "zip_path", "path", "file_path"):
                 if hasattr(rep, attr):
                     p = getattr(rep, attr)
                     if isinstance(p, str) and os.path.exists(p):
                         return p
 
-            # Try saving/exporting
             os.makedirs("/tmp", exist_ok=True)
             target_zip = "/tmp/quality_report.zip"
             if hasattr(rep, "save"):
@@ -115,7 +113,6 @@ class SyntheticDataGenerator:
                 except Exception:
                     pass
 
-            # Fallback: stringify into TXT
             target_txt = "/tmp/quality_report.txt"
             with open(target_txt, "w", encoding="utf-8") as f:
                 f.write(str(rep))
@@ -140,9 +137,9 @@ Memory Usage Estimate:
         """.strip()
 
 
-# App state
+# --- App state ---
 generator = SyntheticDataGenerator()
-_last_synth_df: Optional[pd.DataFrame] = None  # store latest synthetic DF for download
+_last_synth_df: Optional[pd.DataFrame] = None
 
 
 # ---- Gradio wrappers ----
@@ -177,8 +174,8 @@ def generate_data(size: int) -> Tuple[Optional[pd.DataFrame], str]:
         return None, f"Error: {message}"
 
 
-def download_csv_now() -> Optional[str]:
-    """Write the most recent synthetic DF to /tmp and return the path for direct download."""
+def download_csv_prepare() -> Optional[str]:
+    """Return a path to the latest synthetic CSV; used as output to gr.File."""
     global _last_synth_df
     if _last_synth_df is None or _last_synth_df.empty:
         return None
@@ -269,9 +266,11 @@ def create_interface():
                 with gr.Column():
                     train_status = gr.Textbox(label="Training Status", interactive=False)
 
+            # --- Quality report: button + hidden File with download link ---
             with gr.Row():
-                # This download button calls a function that returns a file path → download starts immediately
-                get_report_btn = gr.DownloadButton("Get Quality Report", variant="secondary")
+                get_report_btn = gr.Button("Get Quality Report", variant="secondary")
+                with gr.Group(visible=False) as report_group:
+                    report_file = gr.File(label="Quality Report", interactive=False)
 
         with gr.Tab("Generate Data"):
             gr.Markdown("### Generate synthetic data from your trained model")
@@ -283,9 +282,12 @@ def create_interface():
                     gen_status = gr.Textbox(label="Generation Status", interactive=False)
 
             synthetic_data = gr.Dataframe(label="Synthetic Data", interactive=False)
+
+            # --- CSV download: button + hidden File with download link ---
             with gr.Row():
-                # Same pattern: click → function returns the CSV path → immediate download
-                download_btn = gr.DownloadButton("Download CSV", variant="secondary")
+                csv_download_btn = gr.Button("Download CSV", variant="secondary")
+                with gr.Group(visible=False) as csv_group:
+                    csv_file = gr.File(label="Synthetic CSV", interactive=False)
                 comparison_plot = gr.Plot(label="Data Comparison")
 
         # ---- Events ----
@@ -297,16 +299,38 @@ def create_interface():
             outputs=[train_status],
         )
 
-        # IMPORTANT: For DownloadButton, do NOT specify outputs — the returned path is auto-downloaded.
-        get_report_btn.click(generator.get_quality_report_file, inputs=None, outputs=None)
+        # Quality report: on click, return filepath to gr.File and reveal its group
+        def _prepare_report_for_download():
+            path = generator.get_quality_report_file()
+            if path:
+                return path, gr.update(visible=True)
+            else:
+                # keep group hidden and clear file if nothing
+                return None, gr.update(visible=False)
+
+        get_report_btn.click(
+            _prepare_report_for_download,
+            outputs=[report_file, report_group],
+        )
 
+        # Generate data
         generate_btn.click(generate_data, inputs=[gen_size], outputs=[synthetic_data, gen_status])
 
         # Build comparison plot when both datasets are available
         synthetic_data.change(create_comparison_plot, inputs=[uploaded_data, synthetic_data], outputs=[comparison_plot])
 
-        # CSV download: return a path from the click handler (no outputs)
-        download_btn.click(download_csv_now, inputs=None, outputs=None)
+        # CSV download: write CSV and reveal the file link
+        def _prepare_csv_for_download():
+            path = download_csv_prepare()
+            if path:
+                return path, gr.update(visible=True)
+            else:
+                return None, gr.update(visible=False)
+
+        csv_download_btn.click(
+            _prepare_csv_for_download,
+            outputs=[csv_file, csv_group],
+        )
 
         # File upload handler
         def process_uploaded_file(file):